Validation rules a little bit earlier. We didn't go ahead and validate that. This was an email address Obviously really important and you probably caught that Let's go ahead and just add in the email validation rule in here and go ahead and run our tests everything that's good But let's go ahead and write a specific test just to make sure that this is validated as an email address

00:28

And of course, you don't really need to do this, but it would help So if we go ahead and open up the team invite controller test, let's take a look at some of the tests We have already so it creates an invite if email is already invited to another team. We don't really have any validation Rules in here at the moment. So let's do this under it creates an invite

00:46

So let's go down and create out another one and we do actually have a requires email address. So let's take that test So let's call this valid email address So we did actually test that it needed an email address and let's go ahead and pass that into here So let's take the email and we'll just assign that any string which of course is not a valid email address

01:08

okay, let's go ahead and take out the test in isolation and we'll go ahead and run this and Sure enough that passes great Okay, so super important and obviously you can replicate this for anywhere else across the system where we have any other validation rules You can write individual tests for them as well. So now that we've added in that we know that we need a valid email

Episode summary

In this episode, we're fixing up our invitation feature by making sure that only valid email addresses can be used when inviting someone. Previously, we set up some validation rules, but we totally missed actually checking if the email was, well, actually an email address!

So, we go back into our code and add a proper email validation rule. To make sure this works, we hop over to our tests. We already had a test for requiring an email address, but nothing specifically checking if it’s a valid email. So we write a new test, purposely give it a string that’s not an email, and run our tests to see if the validation catches it.

Everything passes, and we talk a bit about how you can and should write these kinds of tests for your other validation rules across the system. Overall, it’s a quick but important episode on tightening things up and making sure our invites don’t go to totally bogus addresses.

Episode discussion

No comments, yet. Be the first!